linux-kernel - Re: [PATCH] kbuild: Fix compiler warning with assertion when calling 'fwrite'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120114231902.GB19267@sepie.suse.cz>
Date:	Sun, 15 Jan 2012 00:19:03 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Jean Sacren <sakiwit@...il.com>
Cc:	Arnaud Lacombe <lacombar@...il.com>,
	Reinhard Tartler <Reinhard.Tartler@...ormatik.uni-erlangen.de>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	amwang@...hat.com
Subject: Re: [PATCH] kbuild: Fix compiler warning with assertion when calling
 'fwrite'

On Fri, Nov 25, 2011 at 04:42:53PM -0700, Jean Sacren wrote:
> Reinhard Tartler discovered a corner case of calling xfwrite() where the
> length of the string is zero.
> 
> Arnaud Lacombe suggested to use assertion for the corner case, as
> fwrite(3) is currently used:
> 
>  1) in comment printers. Empty comment are not allowed.
>  2) in a callback passed to expr_print(), where the string printed is
>     either NULL OR non-empty.
>  3) in the lexer, auto-generated, and unused.
> 
> I feel using assertion is a good solution:
> 
>  1) It cleanly takes care of the above-mentioned corner case.
>  2) It can be easily disabled by defining NDEBUG.
>  3) It asserts xfwrite() is simply a wrapper for fwrite().
> 
> Reported-by: Reinhard Tartler <Reinhard.Tartler@...ormatik.uni-erlangen.de>
> Signed-off-by: Arnaud Lacombe <lacombar@...il.com>
> Signed-off-by: Jean Sacren <sakiwit@...il.com>

Applied to kbuild.git#kconfig.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/