linux-kernel - Re: [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxuEzfAOL=pH1m7KQxdO1yzz=nGb2fU80AbysFd3J4Dvg@mail.gmail.com>
Date:	Sat, 14 Jan 2012 15:43:01 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Petr Matousek <pmatouse@...hat.com>,
	linux-scsi@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	James Bottomley <JBottomley@...allels.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition devices

On Thu, Jan 12, 2012 at 7:01 AM, Paolo Bonzini <pbonzini@...hat.com> wrote:
> +       case CDROM_GET_CAPABILITY:
> +               /* Keep this until we remove the printk below.  udev sends it
> +                * and we do not want to spam dmesg about it.   CD-ROMs do
> +                * not have partitions, so we get here only for disks.
> +                */
> +               return -ENOIOCTLCMD;

Looks like CDROMMULTISESSION is another of these.

I get two of these:

   mount: sending ioctl 5310 to a partition!

with Fedora 14 whenever a USB stick is inserted (I changed your patch
to also print the name of the program). Let's see if anything else
pops up.

Anyway, with the changes to print out warnings and still allow it for
root, this all looked safe and nice, so they are in my tree now. I
only noticed after applying them that you hadn't marked them with 'cc:
stable@...nel.org', so we should probably point Greg at them. They are
commits

  577ebb374c78 block: add and use scsi_blk_cmd_ioctl
  0bfc96cb7722 block: fail SCSI passthrough ioctls on partition devices
  ec8013beddd7 dm: do not forward ioctls from logical volumes to the
underlying device

in my tree now.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/