linux-kernel - Re: [GIT PULL] target: Updates for v3.3-rc1 (round 1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1326554397.3293.13.camel@dabdike.airangel.com>
Date:	Sat, 14 Jan 2012 15:19:57 +0000
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Bart Van Assche <bvanassche@....org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	Roland Dreier <roland@...nel.org>,
	J?rn Engel <joern@...estorage.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [GIT PULL] target: Updates for v3.3-rc1 (round 1)

On Wed, 2012-01-11 at 05:49 -0500, Christoph Hellwig wrote:
> On Tue, Jan 10, 2012 at 01:51:07PM -0600, James Bottomley wrote:
> > > The changes since the Nov 4 RFC are listed in the patch commit log:
> > > 
> > > ib_srpt: Make compilation with BUG=n proceed`
> > > ib_srpt: Use new target_core_fabric.h include
> > > ib_srpt: Check hex2bin() return code to silence build warning
> > > 
> > > These are all very minor and did not warrant another full RFC posting.
> > 
> > They might not warrant a full RFC reposting, but individually they
> > should have been posted to the list, so Bart is right.
> 
> At least 2 and 3 list, just not as global patches against the
> target tree, not ib_srpt specificly:
> 
> 2 is from: [PATCH] target: header reshuffle, part2
> 3 is from: [PATCH 5/5] target: check hex2bin result
> 
> Not sure about 1.
> 
> I'm really getting tired of this bickering. It's a brand new driver and
> doesn't have to be perfect.  While Bart generally has technically good
> points there's really no reason to put his remaining fixups in after
> the driver has been merged and available to a wieder audience.

Absolutely.  I was just reminding about git best practises, not NAKing a
pull.  Putting this in the kernel and sorting out the rough edges later
is fine by me ... just make sure the rough edges go over the list ...

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/