linux-kernel - Re: [dm-devel] [PATCH] drivers/md/dm-ioctl.c::target_message(): don't leak 'argv' mem

Open Source and information security mailing list archives

Date:	Sun, 15 Jan 2012 17:28:20 -0500 (EST)
From:	Mikulas Patocka <mpatocka@...hat.com>
To:	device-mapper development <dm-devel@...hat.com>
cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [dm-devel] [PATCH] drivers/md/dm-ioctl.c::target_message():
 don't leak 'argv' mem

Acked-by: Mikulas Patocka <mpatocka@...hat.com>

BTW., it should be also backported to RHEL-6.

Mikulas

On Sun, 15 Jan 2012, Jesper Juhl wrote:

> If, after allocating memory for 'argv' via dm_split_args(...), we take
> the true branch of 'if (!argc)', we'll jump to the 'out:' label and
> neglect to free the memory we allocated. We should instead jump to the
> 'out_argv:' label in that case as far as I can tell.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  drivers/md/dm-ioctl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
>  Compile tested only.
> 
> diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
> index 31c2dc2..1ce84ed 100644
> --- a/drivers/md/dm-ioctl.c
> +++ b/drivers/md/dm-ioctl.c
> @@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioctl *param, size_t param_size)
>  
>  	if (!argc) {
>  		DMWARN("Empty message received.");
> -		goto out;
> +		goto out_argv;
>  	}
>  
>  	table = dm_get_live_table(md);
> -- 
> 1.7.8.3
> 
> 
> -- 
> Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
> 
> --
> dm-devel mailing list
> dm-devel@...hat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives