linux-kernel - Re: [PATCH] KVM: MMU: increment stats after event occurrence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F12DCDA.7040706@redhat.com>
Date:	Sun, 15 Jan 2012 16:04:10 +0200
From:	Avi Kivity <avi@...hat.com>
To:	dave@....org
CC:	Takuya Yoshikawa <yoshikawa.takuya@....ntt.co.jp>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>,
	lkml <linux-kernel@...r.kernel.org>, kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: MMU: increment stats after event occurrence

On 01/13/2012 02:56 PM, Davidlohr Bueso wrote:
> On Fri, 2012-01-13 at 10:24 +0900, Takuya Yoshikawa wrote:
> > (2012/01/13 10:08), Davidlohr Bueso wrote:
> > > From: Davidlohr Bueso<dave@....org>
> > >
> > > It makes more sense to actually increment statistics for tlb flushes and page table entry updates after such _events_ occur, instead of before.
> > 
> > Why?
> > 
> From a logical point of view its better to increase stats once the event
> is processed - usually because it can fail and therefore the stats would
> be incorrect. 
>

That doesn't hold for the cases you change.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/