linux-kernel - Re: [PATCH] watchdog: via_wdt: Staticise wdt_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Jan 2012 10:09:56 +0100
From:	Marc Vertes <marc.vertes@...fox.com>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: via_wdt: Staticise wdt_pci_table

Axel Lin wrote:

> It is only used in this driver, so no need to make the symbol global.
> 

Agree.

Acked-by: Marc Vertes <marc.vertes@...fox.com>

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/watchdog/via_wdt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index 026b4bb..8b24b00 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
>  	pci_disable_device(pdev);
>  }
>  
> -DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> +static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/