linux-kernel - Re: [PATCH 04/11] mm: page_alloc: introduce alloc_contig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.v76giluf3l0zgt@mpn-glaptop>
Date:	Mon, 16 Jan 2012 13:48:11 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Mel Gorman" <mel@....ul.ie>
Cc:	"Marek Szyprowski" <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-media@...r.kernel.org, linux-mm@...ck.org,
	linaro-mm-sig@...ts.linaro.org,
	"Kyungmin Park" <kyungmin.park@...sung.com>,
	"Russell King" <linux@....linux.org.uk>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	"Daniel Walker" <dwalker@...eaurora.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	"Jesse Barker" <jesse.barker@...aro.org>,
	"Jonathan Corbet" <corbet@....net>,
	"Shariq Hasnain" <shariq.hasnain@...aro.org>,
	"Chunsang Jeong" <chunsang.jeong@...aro.org>,
	"Dave Hansen" <dave@...ux.vnet.ibm.com>,
	"Benjamin Gaignard" <benjamin.gaignard@...aro.org>
Subject: Re: [PATCH 04/11] mm: page_alloc: introduce alloc_contig_range()

On Mon, 16 Jan 2012 10:01:10 +0100, Mel Gorman <mel@....ul.ie> wrote:

> On Fri, Jan 13, 2012 at 09:04:31PM +0100, Michal Nazarewicz wrote:
>> >On Thu, Dec 29, 2011 at 01:39:05PM +0100, Marek Szyprowski wrote:
>> >>From: Michal Nazarewicz <mina86@...a86.com>
>> >>+	/* Make sure all pages are isolated. */
>> >>+	if (!ret) {
>> >>+		lru_add_drain_all();
>> >>+		drain_all_pages();
>> >>+		if (WARN_ON(test_pages_isolated(start, end)))
>> >>+			ret = -EBUSY;
>> >>+	}
>>
>> On Tue, 10 Jan 2012 15:16:13 +0100, Mel Gorman <mel@....ul.ie> wrote:
>> >Another global IPI seems overkill. Drain pages only from the local CPU
>> >(drain_pages(get_cpu()); put_cpu()) and test if the pages are isolated.
>>
>> Is get_cpu() + put_cpu() required? Won't drain_local_pages() work?
>>
>
> drain_local_pages() calls smp_processor_id() without preemption
> disabled.

Thanks, I wasn't sure if preemption is an issue.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/