linux-kernel - RE: [PATCH] usb: mv-otg - Fix build if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 15 Jan 2012 18:28:29 -0800
From:	Neil Zhang <zhangwm@...vell.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Chao Xie <cxie4@...vell.com>, Felipe Balbi <balbi@...com>
CC:	Randy Dunlap <rdunlap@...otime.net>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: mv-otg - Fix build if CONFIG_USB is not set

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert@...ux-m68k.org]
> Sent: 2012年1月15日 19:36
> To: Neil Zhang; Chao Xie; Felipe Balbi
> Cc: Randy Dunlap; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org; Geert Uytterhoeven
> Subject: [PATCH] usb: mv-otg - Fix build if CONFIG_USB is not set
> 
> ERROR: "usb_remove_hcd" [drivers/usb/otg/mv_otg.ko] undefined!
> ERROR: "usb_add_hcd" [drivers/usb/otg/mv_otg.ko] undefined!
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> --
> Inpired by drivers/usb/otg/msm_otg.c. Is this correct?
> 
>  drivers/usb/otg/mv_otg.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/otg/mv_otg.c b/drivers/usb/otg/mv_otg.c
> index db0d4fc..b5fbe14 100644
> --- a/drivers/usb/otg/mv_otg.c
> +++ b/drivers/usb/otg/mv_otg.c
> @@ -202,6 +202,7 @@ static void mv_otg_init_irq(struct mv_otg *mvotg)
> 
>  static void mv_otg_start_host(struct mv_otg *mvotg, int on)
>  {
> +#ifdef CONFIG_USB
>  	struct otg_transceiver *otg = &mvotg->otg;
>  	struct usb_hcd *hcd;
> 
> @@ -216,6 +217,7 @@ static void mv_otg_start_host(struct mv_otg *mvotg,
> int on)
>  		usb_add_hcd(hcd, hcd->irq, IRQF_SHARED);
>  	else
>  		usb_remove_hcd(hcd);
> +#endif /* CONFIG_USB */
>  }
> 
>  static void mv_otg_start_periphrals(struct mv_otg *mvotg, int on)
> --
> 1.7.0.4

Thanks for your information.
I think it would be better to add a dependency on USB_EHCI_MV since there is no need to use the OTG driver without enable host.

Best Regards,
Neil Zhang