lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jan 2012 15:27:08 -0500 From: Jeff Garzik <jeff@...zik.org> To: Linus Torvalds <torvalds@...ux-foundation.org> CC: Alan Cox <alan@...rguk.ukuu.org.uk>, Matthew Garrett <mjg@...hat.com>, Lin Ming <ming.m.lin@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [git patches] libata updates for 3.3 On 01/16/2012 03:21 PM, Linus Torvalds wrote: > On Mon, Jan 16, 2012 at 12:02 PM, Linus Torvalds > <torvalds@...ux-foundation.org> wrote: >>> >>> http://www.codon.org.uk/~mjg59/tmp/ahci_quirk_cleanup.diff >> >> Hmm. This with just a setup option to enable it might well be good >> enough. No need for whitelists/blacklists, since we couldn't maintain >> those sanely anyway. > > That patch doesn't work for me. I get a panic in ahci_enable_ahci, > looks like 'mmio' is bogus there (attempting to dereference 0x01ffe6). > > I notice that the PIIX device doesn't have any MMIO at all, it's all > PIO. Maybe there is some "need to enable MMIO thing" too. Or maybe I > used the wrong PCI ID when I added it to the quirk table. Part of the problem with force-enable is that the MMIO BAR may need a value, and not have it. That, and an expectations mismatch between BIOS and kernel WRT mode (IDE/AHCI) has always been the reason why 'ahci=force' never made it in. It just never seemed to be reliable broadly. I'm happy with anything we can get working reliably, even with the obvious proviso that 'ahci=force' would be a default-off, user-enabled option. It's always been motherboard/BIOS issues that got in the way. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists