linux-kernel - Re: [PATCH] mm/backing-dev.c: fix crash when USB/SCSI device is detached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOAMb1B7oENhPzgUkFjzuJ0==dnHRJkmHFSq-7QtSGeV6JeBvA@mail.gmail.com>
Date:	Mon, 16 Jan 2012 15:34:09 +0900
From:	Chanho Min <chanho0207@...il.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Rabin Vincent <rabin@....in>, Jens Axboe <axboe@...nel.dk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/backing-dev.c: fix crash when USB/SCSI device is detached

> But wait.. Rabin's patch actually fixes the NULL deference in
> the call
>
>        trace_writeback_wake_forker_thread(bdi);
>
> The wakeup of the forker thread should be harmless.
>
The forker thread shoud not be woken up after the bdi is unregistered.
Is this also Rabin's intention?
Also, I'm not sure the wakeup of the forker thread is harmless as bellows.
..
case FORK_THREAD:
..
  task = kthread_create(bdi_writeback_thread, &bdi->wb,
		      "flush-%s", dev_name(bdi->dev));

Thanks
Chanho
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/