linux-kernel - Re: [PATCH] menuconfig: fix a regression when canceling the prompt dialog at exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120116080516.GA7447@udknight>
Date:	Mon, 16 Jan 2012 16:05:16 +0800
From:	Wang YanQing <udknight@...il.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Michal Marek <mmarek@...e.cz>, Cong Wang <amwang@...hat.com>,
	Arnaud Lacombe <lacombar@...il.com>,
	Davidlohr Bueso <dave@....org>,
	LKML <linux-kernel@...r.kernel.org>, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] menuconfig: fix a regression when canceling the prompt
 dialog at exit

On Mon, Jan 16, 2012 at 03:57:39PM +0800, Li Zefan wrote:
> This commit fixes a bug, while introducing a new one..
> 
> commit 7203ddbd4be9720649e47d756a001e0c7d7f8ae2
> Author: Wang YanQing <udknight@...il.com>
> Date:   Thu Jan 12 11:31:32 2012 +0800
> 
>     menuconfig: let make not report error when not save configuration
> 
> Pressing ESC should cancel the yes/no dialog and return back to
> the main menu, but not exit from menuconfig.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Acked-by: Wang YanQing <udknight@...il.com>

> ---
>  scripts/kconfig/mconf.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 86cd1ea..2c6286c 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -830,7 +830,8 @@ static int handle_exit(void)
>  		fprintf(stderr, _("\n\n"
>  				  "Your configuration changes were NOT saved."
>  				  "\n\n"));
> -		res = 0;
> +		if (res != KEY_ESC)
> +			res = 0;
>  	}
>  
>  	return res;
> -- 
> 1.7.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/