linux-kernel - Re: [GIT PULL] tracing: make signal tracepoints more useful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120117100222.GH10397@elte.hu>
Date:	Tue, 17 Jan 2012 11:02:22 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Seiji Aguchi <saguchi@...hat.com>,
	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [GIT PULL] tracing: make signal tracepoints more useful

* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 2012-01-16 at 13:53 +0100, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > Say if an app relies on the smaller data structure, it sure 
> > might get surprised by the kernel writing a wider record ...
> 
> Ingo,
> 
> The kernel does this all the time. We have syscalls that may 
> extend the data structure. [...]

That is not true *AT ALL* in such an unqualified manner. Steve, 
stop being stupid.

The kernel syscall ABI may indeed sometimes expand *INPUT* 
structures (if via some mechanism it's possible to make sure 
that old ABI uses don't cause the kernel to read undefined 
data), but the trace events are *OUTPUT* structures.

The kernel ABI never ever expands output structures, unless the 
ABI itself is expanded in a safe way that makes it impossible 
for old apps to trigger the new output logic, i.e. which makes 
sure that all old apps work as well. We never ever write beyond 
an already existing 40 byte ABI structure and corrupt the 41th 
byte for an existing app!

In this case we simply don't know whether such an app exists. It 
might be OK to do it, or it might be not so ok.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/