linux-kernel - Re: [PATCH][GIT PULL][v3.3] tracing: Add header wrappers event_headers_start.h and event_headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326807145.17534.26.camel@gandalf.stny.rr.com>
Date:	Tue, 17 Jan 2012 08:32:25 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH][GIT PULL][v3.3] tracing: Add header wrappers
 event_headers_start.h and event_headers_end.h

On Tue, 2012-01-17 at 10:54 +0100, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 

> Hm, i don't really like the extra complexity - this code 
> *really* does not need any more complexity ...

I agree.

> 
> How about the low-tech solution of adding some text between
> '/* */' markers to warns that these headers should not be 
> included in ordinary headers?

The problem is that they currently are. For example:

include/linux/interrupt.h

has one to add a tracepoint in __raise_softirq_irqoff()

Which is fine, as long as no other tracepoint header includes
linux/interrupt.h.

There's also one in module.h.

> 
> The build error will pinpoint the bug anyway, it's not like the 
> kernel can be broken in any dangerous way.

OK, I'll put away these patches. For now we can try to keep all
tracepoints out of header files as much as possible. They really
shouldn't be in static inline functions anyway, because they tend to
bloat the kernel, as we saw when it was included in slab_def.h

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/