linux-kernel - Re: [PATCH] kconfig: untangle EXPERT and EMBEDDED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120117144644.GC3188@turtle.usersys.redhat.com>
Date:	Tue, 17 Jan 2012 15:46:44 +0100
From:	Andrew Jones <drjones@...hat.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Jerome Marchand <jmarchan@...hat.com>,
	Arnd Bergmann <arnd@...db.de>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu,
	david.woodhouse@...el.com, gregkh@...e.de, davem@...emloft.net,
	axboe@...nel.dk, holt@....com, linux-arch@...r.kernel.org,
	linux@....linux.org.uk, hskinnemoen@...il.com,
	egtvedt@...fundet.no, msalter@...hat.com, a-jacquiot@...com,
	starvik@...s.com, jesper.nilsson@...s.com, dhowells@...hat.com,
	takata@...ux-m32r.org, geert@...ux-m68k.org,
	yasutake.koichi@...panasonic.com, jonas@...thpole.se,
	kyle@...artin.ca, deller@....de, jejb@...isc-linux.org,
	chris@...kel.net, greg@...ah.com, davej@...hat.com,
	airlied@...ux.ie, jkosina@...e.cz, mchehab@...radead.org,
	johannes@...solutions.net, linville@...driver.com
Subject: Re: [PATCH] kconfig: untangle EXPERT and EMBEDDED

On Mon, Jan 16, 2012 at 03:37:01PM -0800, David Rientjes wrote:
> > For instance, Why would CONFIG_EXPERT disable by default some HID devices?
> > I could understand why it is done for CONFIG_EMBEDDED, but certainly not
> > for an general EXPERT option.
> > 
> 
> Then this is a prime example that you've identified were it would make 
> sense to have the default value be dependant on EMBEDDED rather than 
> EXPERT.  Feel free to send a patch to the HID maintainers.
> 

How would you propose to write this patch? You say the default value
should be dependant on EMBEDDED, instead of EXPERT? So maybe something
like

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a421abd..73c2d39 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -63,7 +63,7 @@ menu "Special HID drivers"
 config HID_A4TECH
        tristate "A4 tech mice" if EXPERT
        depends on USB_HID
-       default !EXPERT
+       default !EMBEDDED
        ---help---
        Support for A4 tech X5 and WOP-35 / Trust 450L mice.

and the other HID drivers...

I guess it could be changed to 'if EXPERT || EMBEDDED', but at the moment
EMBEDDED selects EXPERT, so that's not currently necessary. I guess what's
above should be sufficient then. Oh, wait! That's exactly what this patch
does! And anybody who actually read it would have seen that.

I'm sorry if my writing style is starting to become a bit sarcastic. I
tend to get that way when I'm overly irritated. And I tend to get
irritated when people nack patches without reading them.

BTW, the HID maintainer, Jiri Kosina, is already on cc, since I cc'ed
every maintainer of the files that this patch touches.

Drew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/