linux-kernel - Re: [PATCH] drm/i915: Use kcalloc instead of kzalloc to allocate array

Open Source and information security mailing list archives

Message-ID: <20120117163339.GR4093@phenom.ffwll.local>
Date:	Tue, 17 Jan 2012 17:33:39 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Use kcalloc instead of kzalloc to allocate
 array

On Tue, Nov 29, 2011 at 10:08:00PM +0100, Thomas Meyer wrote:
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
> 
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

Queued for -next, thanks for the patch.
-Daniel

> ---
> 
> diff -u -p a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> --- a/drivers/gpu/drm/i915/intel_bios.c 2011-11-13 11:07:23.820113543 +0100
> +++ b/drivers/gpu/drm/i915/intel_bios.c 2011-11-28 19:49:51.443206904 +0100
> @@ -572,7 +572,7 @@ parse_device_mapping(struct drm_i915_pri
>  		DRM_DEBUG_KMS("no child dev is parsed from VBT\n");
>  		return;
>  	}
> -	dev_priv->child_dev = kzalloc(sizeof(*p_child) * count, GFP_KERNEL);
> +	dev_priv->child_dev = kcalloc(count, sizeof(*p_child), GFP_KERNEL);
>  	if (!dev_priv->child_dev) {
>  		DRM_DEBUG_KMS("No memory space for child device\n");
>  		return;
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Mail: daniel@...ll.ch
Mobile: +41 (0)79 365 57 48
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives