linux-kernel - Re: [PATCH 2/7] ftrace: Add enable/disable ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120117022905.GE24200@somewhere.redhat.com>
Date:	Tue, 17 Jan 2012 03:29:09 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Jiri Olsa <jolsa@...hat.com>, mingo@...hat.com, paulus@...ba.org,
	acme@...stprotocols.net, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org, aarapov@...hat.com
Subject: Re: [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control
 interface

On Mon, Jan 16, 2012 at 09:07:35PM -0500, Steven Rostedt wrote:
> On Tue, 2012-01-17 at 02:42 +0100, Frederic Weisbecker wrote:
> >  
> > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> > > index 523640f..0d43a2b 100644
> > > --- a/include/linux/ftrace.h
> > > +++ b/include/linux/ftrace.h
> > > @@ -35,12 +35,14 @@ enum {
> > >  	FTRACE_OPS_FL_ENABLED		= 1 << 0,
> > >  	FTRACE_OPS_FL_GLOBAL		= 1 << 1,
> > >  	FTRACE_OPS_FL_DYNAMIC		= 1 << 2,
> > > +	FTRACE_OPS_FL_CONTROL		= 1 << 3,
> > 
> > Please comment the role of this flag. In fact it would be nice to have
> > a comment that explains all these. GLOBAL and DYNAMIC don't actually give
> > much clues alone.
> 
> Someone else asked about commenting these (was it you?).

Probably, as I asked you the meaning of that GLOBAL on irc :)

> I probably should, as it is confusing to what they are used for.

Yeah that would be nice.

> I just figured every just figures it out by looking at the code ;-)

That's often what happens when the reader of the code is also the writer :)
Also, there is no user that doesn't have FTRACE_OPS_FL_GLOBAL yet, so
it's hard to find a counter example.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/