linux-kernel - Re: [RFC] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120117181436.GA21807@redhat.com>
Date:	Tue, 17 Jan 2012 19:14:36 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Tejun Heo <tj@...nel.org>, Andrew Vagin <avagin@...nvz.org>,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [RFC] fs, proc: Introduce /proc/<pid>/task/<tid>/children
	entry v6

On 01/17, Cyrill Gorcunov wrote:
>
> On Tue, Jan 17, 2012 at 06:40:49PM +0100, Oleg Nesterov wrote:
> ...
> > > >
> > > > But this is not enough. exit_ptrace() can do list_move() without
> > > > changing ->real_parent.
> > > >
> > > > I'll try to think. At first glance we can rely on EXIT_DEAD, but
> > > > I'd like to avoid this, I think EXIT_DEAD should die.
> > >
> > > Ouch! Thanks for catching this Oleg. I'll try to come with something
> > > to show as well.
> >
> > Do you see another approach? I don't, so I'd suggest to check
> > "task->exit_state != EXIT_DEAD" instead of !list_empty().
> >
>
> Well, I thought what if I can find another way without EXIT_DEAD
> but seems there is no luck.

Oooooh. Cyrill, it seems I managed to confuse you. And myself.

exit_ptrace() doesn't use ->sibling, it uses ->ptrace_entry!.

Sorry!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/