linux-kernel - Re: [PATCH 06/07] LEDS: LED module for DA9052/53 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120117200227.GC31854@sirena.org.uk>
Date:	Tue, 17 Jan 2012 20:02:27 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Dajun Chen <Dajun.Chen@...semi.com>
Subject: Re: [PATCH 06/07] LEDS: LED module for DA9052/53 PMIC

On Tue, Jan 17, 2012 at 06:58:24PM +0530, Ashish Jangam wrote:

> +	error = da9052_reg_write(led->da9052, led_reg[led->led_index],
> +				 led->brightness | DA9052_LED_CONT_DIM);

The device has 8 bit registers but brightness could be any 8 bit number
by default (and the driver doesn't set a maxmimum brightness that I
noticed).

> +static int __init da9052_led_init(void)
> +{
> +	return platform_driver_register(&da9052_led_driver);
> +}
> +module_init(da9052_led_init);
> +
> +static void __exit da9052_led_exit(void)
> +{
> +	platform_driver_unregister(&da9052_led_driver);
> +}
> +module_exit(da9052_led_exit);

Use module_platform_driver()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/