lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Jan 2012 00:20:03 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: Patrik Jakobsson <patrik.r.jakobsson@...il.com> cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, Alan Cox <alan@...ux.intel.com> Subject: Re: [PATCH] intel, gma500, lvds: Fix use after free and mem leak in psb_intel_lvds_init() On Tue, 17 Jan 2012, Patrik Jakobsson wrote: > On Sat, Jan 14, 2012 at 10:15 PM, Jesper Juhl wrote: > > In psb_intel_lvds_init(), if we fail to allocate memory for > > 'psb_intel_connector' we free the memory we previously allocated for > > 'psb_intel_encoder', but we then proceed to use that free'd pointer > > when we do 'psb_intel_encoder->dev_priv = lvds_priv;'. > > > > We may also leak the memory we allocated for 'psb_intel_encoder' if we > > 'goto failed_connector;' and the variable goes out of scope. > > > > While I was there anyway, I also removed the pointless 'if > > (psb_intel_connector)' before freeing it at the 'failed_connector:' > > label - kfree() deals gracefully with NULL pointers, so it is not > > needed. > > My bad, thanks for fixing No problem :-) Now I just hope that it will get merged :-) -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists