linux-kernel - Re: [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326772723.2819.167.camel@deadeye>
Date:	Tue, 17 Jan 2012 03:58:43 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Petr Matousek <pmatouse@...hat.com>,
	linux-scsi@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	James Bottomley <JBottomley@...allels.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition
 devices

On Mon, 2012-01-16 at 09:51 +0100, Paolo Bonzini wrote:
> On 01/15/2012 12:43 AM, Linus Torvalds wrote:
> > Anyway, with the changes to print out warnings and still allow it for
> > root, this all looked safe and nice, so they are in my tree now. I
> > only noticed after applying them that you hadn't marked them with 'cc:
> > stable@...nel.org', so we should probably point Greg at them. They are
> > commits
> >
> >    577ebb374c78 block: add and use scsi_blk_cmd_ioctl
> >    0bfc96cb7722 block: fail SCSI passthrough ioctls on partition devices
> >    ec8013beddd7 dm: do not forward ioctls from logical volumes to the
> > underlying device
> >
> > in my tree now.
> 
> I'll tweak them myself for stable based on what you committed, so that 
> they do not require your ENOTTY/ENOIOCTLCMD change (i.e. with the uglier 
> v1 implementation).
> 
> Thanks very much.

Paolo, I've just done this for Debian's stable kernel based on 2.6.32.
I'll send them as a follow-up to this.

Ben.

-- 
Ben Hutchings
When in doubt, use brute force. - Ken Thompson

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)