linux-kernel - Re: [PATCH V2 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118093620.GC1068@n2100.arm.linux.org.uk>
Date:	Wed, 18 Jan 2012 09:36:20 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	vinod.koul@...el.com, dan.j.williams@...el.com,
	rajeev-dlh.kumar@...com, bhupesh.sharma@...com,
	linus.walleij@...aro.org, mirko.gardi@...com, perex@...ex.cz,
	vipin.kumar@...com, vipulkumar.samar@...com, egtvedt@...fundet.no,
	pratyush.anand@...com, deepak.sikri@...com, cjb@...top.org,
	hskinnemoen@...il.com, bhavna.yadav@...com,
	armando.visconti@...com, shiraz.hashim@...com, amit.virdi@...com,
	vincenzo.frascino@...com, ulf.hansson@...ricsson.com,
	linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, viresh.linux@...il.com,
	kernel@...gutronix.de
Subject: Re: [PATCH V2 08/12] dmaengine/dw_dmac: Unmap all memory buffers
	after completion of slave transfers

On Wed, Jan 18, 2012 at 02:41:55PM +0530, Viresh Kumar wrote:
> Currently, after completion of transfer, source address or destination address
> of only the first LLI descriptor is unmapped. And length passed for unmap is
> total length of all descriptors in the list. Which means unmapping code assumed
> that the memory buffers pointed to by the descriptors will be physically
> contiguous, which might not be the case. It is possible for other drivers to
> pass sglist to slave_sg(), in which all buffers are scattered throughout the
> memory.
> 
> This patch intends to fix this wrong expectation of dw_dmac. Now, first desc
> will not contain total length of transfer. But individual descriptors will
> contain their individual lengths. Finally, we will call unmap for all
> descriptors.

NAK.  For reasons stated previously and subsequently ignored.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/