linux-kernel - Re: [patch] nfsd: oopses in cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118095501.GD3356@mwanda>
Date:	Wed, 18 Jan 2012 12:55:01 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Sasha Levin <levinsasha928@...il.com>,
	linux-kernel@...r.kernel.org, Neil Brown <neilb@...e.de>,
	linux-nfs@...r.kernel.org
Subject: Re: [patch] nfsd: oopses in cache_parse()

On Mon, Jan 16, 2012 at 10:50:31AM -0500, J. Bruce Fields wrote:
> On Mon, Jan 16, 2012 at 02:52:58PM +0300, Dan Carpenter wrote:
> > We fixed expkey_parse() in b2ea70afad "nfsd: Fix oops when parsing a
> > 0 length export" but there are other cache_parse() implimentations
> > which have the same issue.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> > Since half of the implimentations get this wrong, maybe we should
> > just check for this in cache_do_downcall().  Is there ever a valid
> > reason to pass a zero length string to cache_parse()?
> 
> I don't think so, no.  Checking in cache_do_downcall() sounds like a
> good idea.

Yeah.  I checked and none of the cache_parse() implementations do
anything with a zero length string.  Ignore that patch, I'll send
another.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)