linux-kernel - Re: [PATCH v2 1/2] Making si

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jan 2012 12:34:19 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Leonid Moiseichuk <leonid.moiseichuk@...ia.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	cesarb@...arb.net, kamezawa.hiroyu@...fujitsu.com,
	emunson@...bm.net, aarcange@...hat.com, riel@...hat.com,
	mel@....ul.ie, rientjes@...gle.com, dima@...roid.com,
	gregkh@...e.de, rebecca@...roid.com, san@...gle.com,
	akpm@...ux-foundation.org, vesa.jaaskelainen@...ia.com
Subject: Re: [PATCH v2 1/2] Making si_swapinfo exportable

On Tue, Jan 17, 2012 at 3:22 PM, Leonid Moiseichuk
<leonid.moiseichuk@...ia.com> wrote:
> If we will make si_swapinfo() exportable it could be called from modules.
> Otherwise modules have no interface to obtain information about swap usage.
> Change made in the same way as si_meminfo() declared.
>
> Signed-off-by: Leonid Moiseichuk <leonid.moiseichuk@...ia.com>
> ---
>  mm/swapfile.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index b1cd120..192cc25 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -5,10 +5,12 @@
>  *  Swap reorganised 29.12.95, Stephen Tweedie
>  */
>
> +#include <linux/export.h>
>  #include <linux/mm.h>
>  #include <linux/hugetlb.h>
>  #include <linux/mman.h>
>  #include <linux/slab.h>
> +#include <linux/kernel.h>
>  #include <linux/kernel_stat.h>
>  #include <linux/swap.h>
>  #include <linux/vmalloc.h>
> @@ -2177,6 +2179,7 @@ void si_swapinfo(struct sysinfo *val)
>        val->totalswap = total_swap_pages + nr_to_be_unused;
>        spin_unlock(&swap_lock);
>  }
> +EXPORT_SYMBOL(si_swapinfo);

FWIW, I'm completely OK with this export:

  Acked-by: Pekka Enberg <penberg@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/