linux-kernel - Re: [PATCH 1/1] libata: blacklist NCQ on WDC WD740ADFD-00NLR4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120118113826.7fc60f12@pyramind.ukuu.org.uk>
Date:	Wed, 18 Jan 2012 11:38:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Simon J. Rowe" <srowe@...e.org.uk>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] libata: blacklist NCQ on WDC WD740ADFD-00NLR4

> Jan 16 21:17:08 gilraen kernel: ata5: SError: { UnrecovData Handshk }
> Jan 16 21:17:08 gilraen kernel: ata5.00: failed command: WRITE DMA EXT
> Jan 16 21:17:08 gilraen kernel: ata5.00: cmd 
> 35/00:68:6f:5d:9a/00:01:00:00:00/e0 tag 0 dma 184320 out
> Jan 16 21:17:08 gilraen kernel:         res 
> 50/00:00:66:5d:9a/00:00:00:00:00/e0 Emask 0x10 (ATA bus error)
> Jan 16 21:17:08 gilraen kernel: ata5.00: status: { DRDY }
> Jan 16 21:17:08 gilraen kernel: ata5: hard resetting link
> Jan 16 21:17:08 gilraen kernel: ata5: SATA link up 1.5 Gbps (SStatus 113 
> SControl 300)
> Jan 16 21:17:08 gilraen kernel: ata5.00: configured for UDMA/133
> Jan 16 21:17:08 gilraen kernel: ata5: EH complete
> 
> Googling revealed that this is often caused by faulty cabling. I moved the 
> power and SATA cables and the problem has now gone but I think the disk should 
> still be added to the blacklist,

We add things to the NCQ blacklist because we have multiple clear cases
showing NCQ problems and preferably vendor confirmation. You have neither
and as you said yourself when you fixed the cables it went away.

Your drive is report UnrecovData Handshk, and its' reporting it on a non
NCQ command in your second example. You had a cable problem.

So NAK this patch

Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/