linux-kernel - Re: Kernel crash in icq_free_icq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118160957.GB30664@google.com>
Date:	Wed, 18 Jan 2012 08:09:57 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Shaohua Li <shaohua.li@...el.com>,
	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: Kernel crash in icq_free_icq_rcu

On Wed, Jan 18, 2012 at 09:20:05AM -0500, Vivek Goyal wrote:
> > Not allocating icq if request is never going to go to elevator as elevator
> > switch was happening makes sense to me.
> > 
> > I tried this patch. It went little further and crashed at a different
> > place. I think this seems to be separate merging issue Tejun is trying
> > to track down.
> 
> Applied Tejun's debug patch to return early and not call into elevator
> for checking whether merge is allowed or not. Things seems to be stable
> now for me.

Yeah, plug merge is calling into elevator code without any
synchronization, so it's bound to be broken.  Given plugging is
per-task, I don't think we really need to query elevator about merging
bio's.  The request is not on elevator and plugging is part of issuing
mechanism, not scheduling, after all.  Jens, what do you think?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/