linux-kernel - RE: [PATCH 1/1] Input: tegra-kbc - remove pre Tegra20 definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1780DAADCB@HQMAIL01.nvidia.com>
Date:	Wed, 18 Jan 2012 08:36:26 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rakesh Iyer <riyer@...dia.com>
CC:	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] Input: tegra-kbc - remove pre Tegra20 definitions

Dmitry Torokhov wrote at Tuesday, January 17, 2012 5:30 PM:
> On Tue, Jan 17, 2012 at 03:26:50PM -0800, Rakesh Iyer wrote:
> > Add support for Tegra30 by correcting definitions. This is necessary to
> > make driver useful in Tegra30.
> 
> So what about older versions? There still could be users...

I wonder if there will be problems with this patch; the loop in
tegra_kbc_report_keys() is going to process 8 bits more of the last
register and the loop in tegra_kbc_config_pins() will now touch one
more row and one more column register. I think these loops should be
limited at run-time based on the SoC actually being executed upon?

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/