linux-kernel - Re: linux-next: build warning in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFyNcD0n9xj5CjGZ9szQQYqGCNtbpXLGctkPZCh6ZdhDYw@mail.gmail.com>
Date:	Wed, 18 Jan 2012 15:47:50 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Matthew Wilcox <matthew.r.wilcox@...el.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build warning in Linus' tree

On Wed, Jan 18, 2012 at 3:36 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/block/nvme.c: In function 'nvme_alloc_ns':
> drivers/block/nvme.c:1336:2: warning: passing argument 2 of 'blk_queue_make_request' from incompatible pointer type [enabled by default]
> include/linux/blkdev.h:830:13: note: expected 'void (*)(struct request_queue *, struct bio *)' but argument is of type 'int (*)(struct request_queue *, struct bio *)'

That's a merge error of mine, resulting from a non-conflicting semantics change.

The type of make_request_fn has changed to void, but the nvme driver
was based on the older version.

It's benign in that in the absence of truly crazy calling conventions
it has no relevance apart from unnecessarily clearing the return value
that now doesn't exist and isn't used, but the warning is clearly
annoying.

I pushed out the obvious fix.

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/