linux-kernel - Re: [PATCH] kvm: fix error handling for out of range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120119112209.GB11381@amt.cnet>
Date:	Thu, 19 Jan 2012 09:22:23 -0200
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Avi Kivity <avi@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alex Williamson <alex.williamson@...hat.com>
Subject: Re: [PATCH] kvm: fix error handling for out of range

On Wed, Jan 18, 2012 at 08:07:09PM +0200, Michael S. Tsirkin wrote:
> find_index_from_host_irq returns 0 on error
> but callers assume < 0 on error. This should
> not matter much: an out of range irq should never happen since
> irq handler was registered with this irq #,
> and even if it does we get a spurious msix irq in guest
> and typically nothing terrible happens.
> 
> Still, better to make it consistent.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  virt/kvm/assigned-dev.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/