linux-kernel - Re: [patch 2/2] [media] ds3000: off by one in ds3000_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120119122202.GJ3294@mwanda>
Date:	Thu, 19 Jan 2012 15:22:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	walter harms <wharms@....de>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	"Igor M. Liplianin" <liplianin@...by>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch 2/2] [media] ds3000: off by one in ds3000_read_snr()

On Thu, Jan 19, 2012 at 11:26:41AM +0100, walter harms wrote:
> >> perhaps it is more useful to do it in the check above ?
> > 
> > It looks like the check is correct but we need to shift all the
> > values by one.  Again, I don't have this hardware, I'm just going by
> > the context.
> > 
> I do not have the hardware either so this is pure theoretical.
> 
> Access to the data field depends on the value of dvbs2_noise_reading/tmp
> even when the data are reasonable like 50/100 snr_reading would become 0
> and the index suddenly is -1.
> 

It's a good point.  I will redo the patch.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)