linux-kernel - Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jan 2012 17:07:39 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	<iommu@...ts.linux-foundation.org>, <linux-kernel@...r.kernel.org>,
	Ohad Ben-Cohen <ohad@...ery.com>,
	David Woodhouse <dwmw2@...radead.org>,
	David Brown <davidb@...eaurora.org>,
	Tony Lindgren <tony@...mide.com>,
	Stuart Yoder <b08248@...il.com>,
	Scott Wood <scottwood@...escale.com>,
	Hiroshi Doyu <hdoyu@...dia.com>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

On Thu, Jan 19, 2012 at 04:46:13PM +0100, Laurent Pinchart wrote:
> > +struct iommu_domain_geometry {
> > +	u64 aperture_start;	/* First address that can be mapped    */
> > +	u64 aperture_end;	/* Last address that can be mapped     */
> 
> Would it make sense to use a platform-dependent type that represents physical 
> addresses instead of u64 ?

Well, u64 is a catch-all datatype which should suit all drivers. Is this
a problem at ARM? We can also go the more complicated way of introducing
an iova_addr_t or something. But if possible I would like to avoid that.

> > @@ -62,7 +70,8 @@ enum iommu_attr {
> >   * @unmap: unmap a physically contiguous memory region from an iommu
> > domain * @iova_to_phys: translate iova to physical address
> >   * @domain_has_cap: domain capabilities query
> > - * @commit: commit iommu domain
> > + * @domain_get_attr: Query domain attributes
> > + * @domain_set_attr: Change domain attributes
> 
> This belongs to the previous patch.

Right, I change that.


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/