linux-kernel - Re: [PATCH 08/12] blkcg: use the usual get blkg path for root blkio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jan 2012 08:17:42 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	axboe@...nel.dk, ctalbott@...gle.com, rni@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/12] blkcg: use the usual get blkg path for root
 blkio_group

Hello,

On Thu, Jan 19, 2012 at 09:41:36AM -0500, Vivek Goyal wrote:
> > This simplifies root blkg handling noticeably for cfq and will allow
> > further modularization of blkcg API.
> 
> Does this work if BLK_CGROUP=n?
> 
> I am trying to think that why did I keep allocating root cgroup statically
> for CFQ. May be the reason was that this group was present even if
> CFQ_GROUP_IOSCHED=n. There was other code which assumed a group to be
> always present and I did not want to put more #ifdef.
> 
> Anyway, if it works well, with BLK_CGROUP=n, then it is fine.

Right, it's currently broken but it shouldn't be too difficult to fix.
Will update the patch.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/