linux-kernel - Re: [BUG] vmstat reports no interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327005616.4826.4.camel@edumazet-laptop>
Date:	Thu, 19 Jan 2012 21:40:16 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Glauber Costa <glommer@...allels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [BUG] vmstat reports no interrupts

Le samedi 14 janvier 2012 à 00:01 +0000, Russell King - ARM Linux a
écrit :
> From: Russell King <rmk+kernel@....linux.org.uk>
> proc: fix /proc/stat intr sum
> 
> Commit 3292beb340c7688 (sched/accounting: Change cpustat fields to an array)
> deleted the code which provides us with the sum of all interrupts in
> the system, causing vmstat to report zero interrupts occuring in the
> system.  Fix this by restoring the code.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> Tested-by: Russell King <rmk+kernel@....linux.org.uk> [on ARM]
> ---
>  fs/proc/stat.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/proc/stat.c b/fs/proc/stat.c
> index d76ca6a..121f77c 100644
> --- a/fs/proc/stat.c
> +++ b/fs/proc/stat.c
> @@ -77,6 +77,8 @@ static int show_stat(struct seq_file *p, void *v)
>  		steal += kcpustat_cpu(i).cpustat[CPUTIME_STEAL];
>  		guest += kcpustat_cpu(i).cpustat[CPUTIME_GUEST];
>  		guest_nice += kcpustat_cpu(i).cpustat[CPUTIME_GUEST_NICE];
> +		sum += kstat_cpu_irqs_sum(i);
> +		sum += arch_irq_stat_cpu(i);
>  
>  		for (j = 0; j < NR_SOFTIRQS; j++) {
>  			unsigned int softirq_stat = kstat_softirqs_cpu(j, i);
> 

Any news on this patch being accepted and pushed to Linus ?

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/