linux-kernel - Re: [PATCH RFC 2/2] OMAP : serial : Check for error in get_context_loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hazrti1c.fsf@ti.com>
Date:	Thu, 19 Jan 2012 14:59:59 -0800
From:	Kevin Hilman <khilman@...com>
To:	Shubhrajyoti D <shubhrajyoti@...com>
Cc:	<linux-serial@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH RFC 2/2] OMAP : serial : Check for error in get_context_loss_count

Shubhrajyoti D <shubhrajyoti@...com> writes:

> In serial_omap_runtime_resume in case of errors returned by
> get_context_loss_count print a warning and do a restore.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@...com>

These two patches should be combined into a single patch.

Also, please Cc Govindraj since he's the maintainer of this driver and
should Ack.

Thanks,

Kevin

> ---
> applies on Tony's uart branch
>
>  drivers/tty/serial/omap-serial.c |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 29fe6fd..6008612 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -1602,10 +1602,16 @@ static int serial_omap_runtime_resume(struct device *dev)
>  
>  	if (up) {
>  		if (pdata->get_context_loss_count) {
> -			u32 loss_cnt = pdata->get_context_loss_count(dev);
> +			int loss_cnt = pdata->get_context_loss_count(dev);
>  
> -			if (up->context_loss_cnt != loss_cnt)
> +			if (loss_cnt < 0) {
> +				dev_err(dev,
> +					"get_context_loss_count failed : %d\n",
> +					loss_cnt);
>  				serial_omap_restore_context(up);
> +			} else if (up->context_loss_cnt != loss_cnt) {
> +				serial_omap_restore_context(up);
> +			}
>  		}
>  
>  		/* Errata i291 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/