linux-kernel - Re: [PATCHv2] backing-dev: fix wakeup timer races with bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120120120801.GA22145@debian>
Date:	Fri, 20 Jan 2012 17:38:08 +0530
From:	Rabin Vincent <rabin@....in>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	fengguang.wu@...el.com, axboe@...nel.dk,
	linux-kernel@...r.kernel.org, chanho0207@...il.com
Subject: Re: [PATCHv2] backing-dev: fix wakeup timer races with
 bdi_unregister()

On Fri, Jan 20, 2012 at 08:18:31PM +0900, Namjae Jeon wrote:
> The following case is not possible with racing of __mark_inode_dirty  ?
> --------------------------------------------------------------------------------------------------
> spin_lock
> bdi->dev = NULL;
> spin_unlock
>                               spin_lock
>                                ......
>                                ......
>                                trace_writeback_wake_forker_thread(bdi);
>                                spin_unlock
> -----------------------------------------------------------------------------

After this patch, this is what wakeup_timer_fn looks like:

static void wakeup_timer_fn(unsigned long data)
{
        struct backing_dev_info *bdi = (struct backing_dev_info *)data;

        spin_lock_bh(&bdi->wb_lock);
        if (bdi->wb.task) {
                trace_writeback_wake_thread(bdi);
                wake_up_process(bdi->wb.task);
        } else if (bdi->dev) {
                /*
                 * When bdi tasks are inactive for long time, they are killed.
                 * In this case we have to wake-up the forker thread which
                 * should create and run the bdi thread.
                 */
                trace_writeback_wake_forker_thread(bdi);
                wake_up_process(default_backing_dev_info.wb.task);
        }
        spin_unlock_bh(&bdi->wb_lock);
}

So how will trace_writeback_wake_forker_thread() be called if bdi->dev is NULL?

This patch added the if (bdi->dev) check, perhaps you overlooked that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/