linux-kernel - Re: [PATCH] [TRIVIAL] perf probe usability related fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F197E6F.5070003@gmail.com>
Date:	Fri, 20 Jan 2012 07:47:11 -0700
From:	David Ahern <dsahern@...il.com>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [TRIVIAL] perf probe usability related fixes.

On 01/20/2012 05:13 AM, Srikar Dronamraju wrote:
> From: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> 
> Ingo pointed out few perf probe usability related errors during
> his review of uprobes.
> 
> Since these issues are independent of uprobes, fixing them in a
> separate patch.
> 
> Suggested-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> ---
>  tools/perf/util/probe-event.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index f6f5794..da38ec5 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1825,7 +1825,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
>  	}
>  
>  	ret = 0;
> -	printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":");
> +	printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");

It's not past tense until after write_probe_trace_event() right? Where
the message is now you can get an error message after that printf.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/