linux-kernel - Re: [PATCH v2] serial: trivial checkpatch fixes in drivers/tty/serial/8250.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F198BAB.3010706@gmail.com>
Date:	Fri, 20 Jan 2012 16:43:39 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Simon Glass <sjg@...omium.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Jiri Kosina <trivial@...nel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-serial@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] serial: trivial checkpatch fixes in drivers/tty/serial/8250.c

On 01/20/2012 01:24 AM, Simon Glass wrote:
> @@ -2006,8 +2010,8 @@ static int serial8250_startup(struct uart_port *port)
>  	 */
>  	if (!(up->port.flags & UPF_BUGGY_UART) &&
>  	    (serial_inp(up, UART_LSR) == 0xff)) {
> -		printk_ratelimited(KERN_INFO "ttyS%d: LSR safety check engaged!\n",
> -				   serial_index(&up->port));
> +		pr_info_ratelimited(

FWIW I hate these macros. Beginners ask what the heck stands "pr" for?

> @@ -3053,8 +3063,8 @@ static int __devinit serial8250_probe(struct platform_device *dev)
>  		port.irqflags		|= irqflag;
>  		ret = serial8250_register_port(&port);
>  		if (ret < 0) {
> -			dev_err(&dev->dev, "unable to register port at index %d "
> -				"(IO%lx MEM%llx IRQ%d): %d\n", i,
> +			dev_err(&dev->dev, "unable to register port at "
> +				"index %d (IO%lx MEM%llx IRQ%d): %d\n", i,

Nack to this. It makes grepping harder.

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/