linux-kernel - Re: [RFC] syscalls, x86: Add __NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jan 2012 20:29:00 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>, david@...g.hm,
	Alexey Dobriyan <adobriyan@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrey Vagin <avagin@...nvz.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <glommer@...allels.com>,
	Andi Kleen <andi@...stfloor.org>, Tejun Heo <tj@...nel.org>,
	Matt Helsley <matthltc@...ibm.com>,
	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Valdis.Kletnieks@...edu
Subject: Re: [RFC] syscalls, x86: Add __NR_kcmp syscall

On Fri, Jan 20, 2012 at 06:51:31AM -0800, H. Peter Anvin wrote:
> On 01/20/2012 01:02 AM, Cyrill Gorcunov wrote:
> > On Fri, Jan 20, 2012 at 12:40:08PM +0400, Cyrill Gorcunov wrote:
> > ...
> >> +
> >> +static __init int kcmp_cookie_init(void)
> >> +{
> >> +	int i, j;
> >> +
> >> +	for (i = 0; i < KCMP_TYPES; i++) {
> >> +		for (j = 0; j < 2; j++) {
> >> +			get_random_bytes(&cookies[i][j], sizeof(cookies[i][j]));
> >> +
> >> +			if (cookies[i][j])
> >> +				continue;
> >> +
> >> +			/*
> >> +			 * This is impossible case but just to be sure.
> >> +			 */
> >> +			cookies_valid = false;
> >> +			WARN_ONCE(1, "Can't get random bytes for k-pointers\n");
> >> +		}
> >> +	}
> >> +
> >> +	cookies_valid = true;
> > 
> > darn, this string of course should be on top,
> > i'll update don't complain on this nit.
> > 
> 
> This code is wrong.  You will have a zero cookie, legitimately, once in
> 2^32 or 2^64 attempts, depending on the bitness.
>

We've had kind of emergency pool before which were used in such cases.
These legitime cases can happen not that frequently, so I guess -- can
we use it again?

	if (cookies[i][j])
		continue;
	else
		cookies[i][j] = some-value;

One wont know which exactly values we were using.

> The other thing is that for the multiplicative cookie you should OR in
> the value (~(~0UL >> 1) | 1) in order to make sure that the value is (a)
> large and (b) odd.
> 

I see, i'll update (at first, I occasionally translated odd as 'even' which
made me really scratching the head, until I realized it's 'odd'! :)

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/