linux-kernel - Re: [PATCH 2/2] mfd: Add support for multiple s5m devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120120182303.GA18762@opensource.wolfsonmicro.com>
Date:	Fri, 20 Jan 2012 18:23:04 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Sangbeom Kim <sbkim73@...sung.com>
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: Add support for multiple s5m devices

On Fri, Jan 20, 2012 at 04:09:12PM +0900, Sangbeom Kim wrote:

Reviewed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

> +	switch (s5m87xx->device_type) {
> +	case S5M8751X:
> +		ret = mfd_add_devices(s5m87xx->dev, -1, s5m8751_devs,
> +					ARRAY_SIZE(s5m8751_devs), NULL, 0);
> +		break;

Does the hardware have ID registers you can use to confirm if the user
got the right device?  Cut'n'pasting of machine definitions can be a bit
error prone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/