linux-kernel - [PATCH 1/1] mm: msync: fix issues of sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327036719-1965-1-git-send-email-zumeng.chen@windriver.com>
Date:	Fri, 20 Jan 2012 13:18:39 +0800
From:	Zumeng Chen <zumeng.chen@...driver.com>
To:	<linux-kernel@...r.kernel.org>
CC:	<torvalds@...ux-foundation.org>, <mingo@...e.hu>,
	<ralf@...ux-mips.org>, <bruce.ashfield@...driver.com>
Subject: [PATCH 1/1] mm: msync: fix issues of sys_msync on tmpfs

This patch fixes two issues as follows:

For some filesystem with fsync == noop_fsync, there is not so much thing
to do, so sys_msync just passes by for all arches but some CPUs.

For some CPUs with cache aliases(dmesg|grep alias), it maybe has an issue,
which reported by msync test suites in ltp-full when the memory of memset
used by msync01 runs into cache alias randomly.

Consider the following scenario used by msync01 in ltp-full:
  fildes = open(TEMPFILE, O_RDWR | O_CREAT, 0666)) < 0);
  .../* initialization fildes by write(fildes); */
  addr = mmap(0, page_sz, PROT_READ | PROT_WRITE, MAP_FILE | MAP_SHARED,
	 fildes, 0);
  /* set buf with memset */
  memset(addr + OFFSET_1, 1, BUF_SIZE);

  /* msync the addr before using, or MS_SYNC*/
  msync(addr, page_sz, MS_ASYNC)

  /* Tries to read fildes */
  lseek(fildes, (off_t) OFFSET_1, SEEK_SET) != (off_t) OFFSET_1) {
  nread = read(fildes, read_buf, sizeof(read_buf));

  /* Then test the result */
  if (read_buf[count] != 1) {

The test result is random too for CPUs with cache alias. So in this
situation, we have to flush the related vma to make sure the read is
correct.

Signed-off-by: Zumeng Chen <zumeng.chen@...driver.com>
---
 mm/msync.c |   30 ++++++++++++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/mm/msync.c b/mm/msync.c
index 632df45..0021a7e 100644
--- a/mm/msync.c
+++ b/mm/msync.c
@@ -13,6 +13,14 @@
 #include <linux/file.h>
 #include <linux/syscalls.h>
 #include <linux/sched.h>
+#include <asm/cacheflush.h>
+
+/* Cache aliases should be taken into accounts when msync. */
+#ifdef cpu_has_dc_aliases
+#define CPU_HAS_CACHE_ALIAS cpu_has_dc_aliases
+#else
+#define CPU_HAS_CACHE_ALIAS 0
+#endif
 
 /*
  * MS_SYNC syncs the entire file - including mappings.
@@ -78,6 +86,28 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
 		}
 		file = vma->vm_file;
 		start = vma->vm_end;
+
+		/*
+		 * For some filesystems with fsync == noop_fsync, msync just
+		 * passes by but some CPUs.
+		 * For CPUs with cache alias, msync has to flush the related
+		 * vma explicitly to make sure data coherency between memory
+		 * and cache, which includes MS_SYNC or MS_ASYNC. That is to
+		 * say, cache aliases should not be an async factor, so does
+		 * msync on other arches without cache aliases.
+		 */
+		if (file && file->f_op && file->f_op->fsync == noop_fsync) {
+			if (CPU_HAS_CACHE_ALIAS)
+				flush_cache_range(vma, vma->vm_start,
+							vma->vm_end);
+			if (start >= end) {
+				error = 0;
+				goto out_unlock;
+			}
+			vma = find_vma(mm, start);
+			continue;
+		}
+
 		if ((flags & MS_SYNC) && file &&
 				(vma->vm_flags & VM_SHARED)) {
 			get_file(file);
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/