linux-kernel - Re: [PATCH V1] mfd: tps65910: Add wakeup support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F1AB634.4090106@nvidia.com>
Date:	Sat, 21 Jan 2012 18:27:24 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"jedu@...mlogic.co.uk" <jedu@...mlogic.co.uk>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH V1] mfd: tps65910: Add wakeup support

On Saturday 21 January 2012 06:21 PM, Mark Brown wrote:
> On Sat, Jan 21, 2012 at 04:54:52PM +0530, Laxman Dewangan wrote:
>
>> During initialization of device, we need to tell that device is
>> wakeup capable and hence we need to call the: device_wakeup_init()
>> and device_set_wakeup_capable(dev, true).
>> Then it exposes the required sysfs to userspace to select the wakeup
>> enable or not i.e. power/wakeup to be written as enabled or
>> disabled.
>> Based on user selection, the function device_may_wakeup() will
>> return true/false based on  power/wakeup enabled/disabled. So before
>> entering into the suspend, we need to check this function and call
>> enable_irq_wakeup() to have the wakeup enabled actually in the soc.
>> In resume we need to call disable_irq_wake() again.
> Yes, that sounds about right.  You don't strictly need to worry about
> the wake setup except when suspending but it tends to be easier to
> implement that way.
Thanks, I will send another patch for implementing this way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/