linux-kernel - Re: [PATCH 4/4] Staging: android: Fix struct definitioni warning from static to const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120121080838.GK3294@mwanda>
Date:	Sat, 21 Jan 2012 11:08:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Kashyap Gada <gada.kashyap@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org, bringert@...roid.com,
	linux-kernel@...r.kernel.org, arve@...roid.com,
	john.stultz@...aro.org, ccross@...roid.com
Subject: Re: [PATCH 4/4] Staging: android: Fix struct definitioni warning
 from static to const

On Sat, Jan 21, 2012 at 02:17:49AM +0000, Kashyap Gada wrote:
> ---
>  drivers/staging/android/ashmem.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 4a00174a5..9f1f27e 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -680,7 +680,7 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  	return ret;
>  }
>  
> -const struct file_operations ashmem_fops = {
> +static const struct file_operations ashmem_fops = {
>  	.owner = THIS_MODULE,
>  	.open = ashmem_open,
>  	.release = ashmem_release,

No.  We're not going to merge the broken patch which removes the
static.

Plus your patch numbering is totally bogus.
[PATCH 2/2]
[PATCH 3/3]
[PATCH 4/4]
[PATCH 5/5]

The second number is supposed to say how many patches there are in
the series.  If these were bug fixes, we'd go out of our way to work
with you, but you're just sending random whitespace fixes so they
have to be pretty much perfect.  (In other words, please slow down
and work more carefully or else focus on fixing bugs instead of
whitespace).

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)