linux-kernel - Re: [PATCH][GIT PULL][v3.3] tracing: Add header wrappers event_headers_start.h and event_headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877h0jgx80.fsf@rustcorp.com.au>
Date:	Mon, 23 Jan 2012 09:29:27 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH][GIT PULL][v3.3] tracing: Add header wrappers event_headers_start.h and event_headers_end.h

On Wed, 18 Jan 2012 12:56:52 -0500, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Wed, 2012-01-18 at 13:07 +0100, Ingo Molnar wrote:
> 
> > I'd argue that __raise_softirq_irqoff() should not be inline - 
> > that would solve a whole host of issues. Event tracing is 
> > enabled in most distros so there's no real overhead argument to 
> > be made here either - so it's probably a bit faster in fact to 
> > have this uninlined. What do you think?
> 
> Sure, I have no problem moving that out of the header. I don't think
> raising a softirq is in that critical a path that it can't be a function
> call.
> 
> There's only one trace/events header left which is in module.h. Perhaps
> we can move __module_get() and try_module_get() out of the header. We
> could just move the "if" part out.

Agreed.  Since GCC should be able to eliminate that branch in almost all
cases, since it's usually a literal NULL or address of a (non-weak)
symbol.

Be interesting to see the before/after sizes with this out-of-line.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/