| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jan 2012 12:03:14 +0000 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Ashish Chavan <ashish.chavan@...tcummins.com> Cc: lrg <lrg@...com>, alsa-devel <alsa-devel@...a-project.org>, David Dajun Chen <david.chen@...semi.com>, "kuninori.morimoto.gx" <kuninori.morimoto.gx@...esas.com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM On Mon, Jan 23, 2012 at 05:39:21PM +0530, Ashish Chavan wrote: > On Mon, 2012-01-23 at 11:21 +0000, Mark Brown wrote: > > On Mon, Jan 23, 2012 at 03:37:21PM +0530, Ashish Chavan wrote: > > ...this code is shared between both branches (as well as the SRM case) > > and should be factored out between them. > We are picking values from three different tables in three cases. Even > if we factor out this code, we will need a switch or if-else to identify > correct table. As we are already checking those conditions, I put the > code there. Can you please elaborate a bit, in case if I misunderstood > your point? The only difference between these relatively large chunks of code is the table that's being referenced. Either use a single table or factor things out so that you're sharing all the code that doesn't pick the table. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists