linux-kernel - Re: [PATCH] kbuild: do not check for ancient modutils tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120123141710.GA26809@sepie.suse.cz>
Date:	Mon, 23 Jan 2012 15:17:10 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Cong Wang <amwang@...hat.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org
Subject: Re: [PATCH] kbuild: do not check for ancient modutils tools

On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:
> On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@...hat.com> wrote:
> > On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
> >> scripts/depmod.sh checks for the output of '-V' expecting that it has
> >> module-init-tools in it. It's a hack to prevent users from using
> >> modutils instead of module-init-tools, that only works with 2.4.x
> >> kernels. This however prints an annoying warning for kmod tool, that is
> >> currently replacing module-init-tools.

You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)

Just kidding.


> >> Rather than putting another check for kmod's version, just remove it
> >> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
> >> do, let depmod fail in that case because they should know what they are
> >> doing.
> >>
> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
> >
> > Acked-by: WANG Cong <amwang@...hat.com>
> 
> Michal, mind picking this up? The warning it produces with kmod is
> really misleading, and the check seems unnecessary these days.

I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/