| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jan 2012 10:23:14 -0500 (EST) From: Alan Stern <stern@...land.harvard.edu> To: Keith Packard <keithp@...thp.com> cc: linux-kernel@...r.kernel.org, <linux-usb@...r.kernel.org>, <linux-bluetooth@...r.kernel.org> Subject: Re: [PATCH] Regression: Revert "Bluetooth: use buffer priority to mark URB_ISO_ASAP flag" On Sun, 22 Jan 2012, Keith Packard wrote: > Ok, so this is a comedy of errors. The Bluetooth code is trying to use > an iso-specific flag (URB_ISO_ASAP) on a bulk endpoint, which is > invalid, but normally harmless. Unless the USB code is compiled for > debugging, in which case it checks a bunch for incorrect usage and > discards URBs which are wrong. > > As far as I'm concerned, #ifdef DEBUG code should never ever change > the behaviour of the code, and so I'd say the USB code is even more > broken than the bluetooth code... Well, if the DEBUG code never changed any behaviors at all, it would be pretty useless, wouldn't it? In this case, the change in behavior involves printing out a kernel message announcing a bug. Causing the submission to fail also helps draw people's attention to the bug. Under the circumstances, I think this is understandable and not truly broken. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists