linux-kernel - Re: [PATCH] sched/stats: Keep legacy array expiration field to zero.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADZ9YHgKBaf-Ln+D9SxzR2RoZ2BiKWqeTzwrX39ns9MJoOgPhA@mail.gmail.com>
Date:	Mon, 23 Jan 2012 22:21:02 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/stats: Keep legacy array expiration field to zero.

On Mon, Jan 23, 2012 at 6:56 PM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> On Thu, 2012-01-19 at 22:37 +0600, Rakib Mullick wrote:
>> A patch (https://lkml.org/lkml/2012/1/12/224) was sent previously to
>> update scheduler stat documentation to address array expiration
>> field's use. Then Ingo suggest that, we should also make sure that
>> we're exporting a value of zero. So, this patch does those
>> accordingly.
>
>
> This is not a valid changelog

Ok, I'll elaborate the changelog. (Actually, I had my finger crossed :) )
>
> This leaves sched_switch completely unused:
>
> # git grep -e "\<sched_switch\>"  kernel/sched/
> kernel/sched/debug.c:   P(sched_switch);
> kernel/sched/sched.h:   unsigned int sched_switch;
> kernel/sched/stats.c:               rq->sched_switch, rq->sched_count, rq->sched_goidle,
>
> Best kill that too
>
I asked on previous posting about removing rq->sched_switch. But
didn't get any specific answer. Anyway, will do it.

Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/