linux-kernel - Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPz4a6AUAMxcMkVkgc9UJ1tok36jNE5hZzJc_9n5EJqRQCcz2w@mail.gmail.com>
Date:	Mon, 23 Jan 2012 09:22:27 -0800
From:	Dima Zavin <dima@...roid.com>
To:	Kashyap Gada <gada.kashyap@...il.com>
Cc:	gregkh@...e.de, rebecca@...roid.com, rschultz@...gle.com,
	jgennis@...gle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk
 () in pmem.c

We really should just get rid of pmem.c altogether. We will remove it
from our android common tree too. We don't actually use it anymore in
any of our products. There are some legacy users of it, like Qualcomm,
but I'm sure they have a bunch of patches on top of it and thus are
maintaining it separately anyway.

--Dima

On Fri, Jan 20, 2012 at 7:24 PM, Kashyap Gada <gada.kashyap@...il.com> wrote:
> diff --git a/drivers/staging/android/pmem.c b/drivers/staging/android/pmem.c
> index 65ba61a..c589c0c 100644
> --- a/drivers/staging/android/pmem.c
> +++ b/drivers/staging/android/pmem.c
> @@ -831,7 +831,7 @@ static int pmem_connect(unsigned long connect, struct file *file)
>        src_file = fget_light(connect, &put_needed);
>        DLOG("connect %p to %p\n", file, src_file);
>        if (!src_file) {
> -               printk("pmem: src file not found!\n");
> +               printk(KERN_ERR "pmem: src file not found!\n");
>                ret = -EINVAL;
>                goto err_no_file;
>        }
> @@ -934,7 +934,7 @@ int pmem_remap(struct pmem_region *region, struct file *file,
>        if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
>                 !PMEM_IS_PAGE_ALIGNED(region->len))) {
>  #if PMEM_DEBUG
> -               printk("pmem: request for unaligned pmem suballocation "
> +               printk(KERN_DEBUG "pmem: request for unaligned pmem suballocation "
>                       "%lx %lx\n", region->offset, region->len);
>  #endif
>                return -EINVAL;
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/