linux-kernel - Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Dx6Ha2BoO39oQjemLa-OJ44J5rAuSYBk7dg0iXRjW8t4FSGQ@mail.gmail.com>
Date:	Tue, 24 Jan 2012 01:07:53 +0530
From:	"Pradeep A. Dalvi" <netdev@...deepdalvi.com>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, netdev@...r.kernel.org, hch@....de,
	linux-kernel@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb

On Tue, Jan 24, 2012 at 12:53 AM, David Miller <davem@...emloft.net> wrote:
> From: "Pradeep A. Dalvi" <netdev@...deepdalvi.com>
> Date: Tue, 24 Jan 2012 00:43:10 +0530
>
>> On Tue, Jan 24, 2012 at 12:23 AM, David Miller <davem@...emloft.net> wrote:
>>> From: Joe Perches <joe@...ches.com>
>>> Date: Mon, 23 Jan 2012 10:40:34 -0800
>>>
>>>> Perhaps you should break this large patch
>>>> into multiple separate patches.
>>>
>>> Agreed, this patch is way too large especially for what is obviously
>>> turning out to be a very non-trivial transformation in some cases
>>> and also new patch submitters should generally avoid large patches
>>> like this.
>>
>> Acked! Will try to separate out trivial & non-trivial changes.
>> Although, still trivial changes would be big enough. And at the same
>> time, splitting changes into 118 patches might turn out to be
>> cumbersome for review.
>
> We didn't say to create 118 patches, we're talking about on the
> order of 4 or 5 patches.

Certainly! Would resubmit the patch splitting across couple of them. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/