linux-kernel - Re: [patch 3/4] c/r: procfs: add arg_start/end, env_start/end and exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJtum19tEKdDAKU3pZYF6k76gpPpwP8ananKhpQDJ8=VQ@mail.gmail.com>
Date:	Mon, 23 Jan 2012 12:42:28 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Tejun Heo <tj@...nel.org>, Andrew Vagin <avagin@...nvz.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [patch 3/4] c/r: procfs: add arg_start/end, env_start/end and
 exit_code members to /proc/$pid/stat

On Mon, Jan 23, 2012 at 6:20 AM, Cyrill Gorcunov <gorcunov@...nvz.org> wrote:
> We would like to have an ability to restore command line
> arguments and envirion pointers so the task being restored
> would print appropriate values in /proc/pid/cmdline and
> /proc/pid/envirion. The exit_code is needed to restore
> zombie tasks.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> Cc: Pavel Emelyanov <xemul@...allels.com>
> Cc: Serge Hallyn <serge.hallyn@...onical.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: Alexey Dobriyan <adobriyan@...il.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Andrew Vagin <avagin@...nvz.org>
> Cc: Vasiliy Kulikov <segoon@...nwall.com>
> Cc: Alexey Dobriyan <adobriyan@...il.com>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> ---
>  fs/proc/array.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> Index: linux-2.6.git/fs/proc/array.c
> ===================================================================
> --- linux-2.6.git.orig/fs/proc/array.c
> +++ linux-2.6.git/fs/proc/array.c
> @@ -464,7 +464,8 @@ static int do_task_stat(struct seq_file
>
>        seq_printf(m, "%d (%s) %c %d %d %d %d %d %u %lu \
>  %lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \
> -%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu\n",
> +%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu \
> +%lu %lu %lu %lu %d\n",
>                pid_nr_ns(pid, ns),
>                tcomm,
>                state,
> @@ -514,7 +515,12 @@ static int do_task_stat(struct seq_file
>                cputime_to_clock_t(cgtime),
>                (mm && permitted) ? mm->start_data : 0,
>                (mm && permitted) ? mm->end_data : 0,
> -               (mm && permitted) ? mm->start_brk : 0);
> +               (mm && permitted) ? mm->start_brk : 0,
> +               (mm && permitted) ? mm->arg_start : 0,
> +               (mm && permitted) ? mm->arg_end : 0,
> +               (mm && permitted) ? mm->env_start : 0,
> +               (mm && permitted) ? mm->env_end : 0,
> +               task->exit_code);
>        if (mm)
>                mmput(mm);
>        return 0;

You're not exposing auxv here? In your testing, what situations ended
up using auxv after initial startup? Or is your intention to be able
to freeze a process potentially before libc has examined auxv?

-Kees

-- 
Kees Cook
ChromeOS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/