[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <201201232209.18700.rjw@sisk.pl>
Date: Mon, 23 Jan 2012 22:09:18 +0100
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: "Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
"linux-kernel" <linux-kernel@...r.kernel.org>,
Linux PM mailing list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 3.3-rc1] PM / Sleep: Fix read_unlock_usermodehelper() call.
On Monday, January 23, 2012, Srivatsa S. Bhat wrote:
> On 01/23/2012 10:19 AM, Tetsuo Handa wrote:
>
> > Commit b298d289
> > "PM / Sleep: Fix freezer failures due to racy usermodehelper_is_disabled()"
> > added read_unlock_usermodehelper() but read_unlock_usermodehelper() is called
> > without read_lock_usermodehelper() when kmalloc() failed.
> >
> > Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> > -----
>
>
> Acked-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
Applied.
Thanks,
Rafael
> > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> > index 26ab358..6c9387d 100644
> > --- a/drivers/base/firmware_class.c
> > +++ b/drivers/base/firmware_class.c
> > @@ -525,8 +525,7 @@ static int _request_firmware(const struct firmware **firmware_p,
> > if (!firmware) {
> > dev_err(device, "%s: kmalloc(struct firmware) failed\n",
> > __func__);
> > - retval = -ENOMEM;
> > - goto out;
> > + return -ENOMEM;
> > }
> >
> > if (fw_get_builtin_firmware(firmware, name)) {
> >
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists